Skip to content

Alpha.52 update#99

Merged
IgorMinar merged 2 commits intoangular:masterfrom
IgorMinar:alpha.52-update
Dec 10, 2015
Merged

Alpha.52 update#99
IgorMinar merged 2 commits intoangular:masterfrom
IgorMinar:alpha.52-update

Conversation

@IgorMinar
Copy link
Copy Markdown
Contributor

No description provided.

@IgorMinar
Copy link
Copy Markdown
Contributor Author

@cironunes please review and merge if no issues found and CI passes

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you prefer to use .bind?

@cironunes
Copy link
Copy Markdown
Member

I added two minor comments that are much more about style preferences. Otherwise lgtm.

@IgorMinar
Copy link
Copy Markdown
Contributor Author

The file you commented on is transpiled version of files we have in the
angular/angular repo. We should not hand-modify them here.

One day all these plugins will come from npm, but today is not that day 😀
On Thu, Dec 10, 2015 at 4:06 AM Ciro Nunes notifications@github.com wrote:

I added two minor comments that are much more about style preferences.
Otherwise lgtm.


Reply to this email directly or view it on GitHub
#99 (comment).

@IgorMinar
Copy link
Copy Markdown
Contributor Author

ci green. merging

@IgorMinar IgorMinar merged commit 563e6e2 into angular:master Dec 10, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants